sphinx: return error source as integer #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
error-source-idx
branch
from
991dab9
to
cd516f6
Compare
Roasbeef
reviewed
Jun 28, 2019
The sender doesn't know whether the failure happened on the first or the second visit of that node. |
Roasbeef
reviewed
Jun 29, 2019
joostjager
force-pushed
the
error-source-idx
branch
from
4e4a958
to
ad3ab31
Compare
|
@Roasbeef fixup pushed that adds return struct. I still don't think it is good, for the reasons pointed out above. But it is a small change and the most important thing is to expose the index one way or the other. |
|
@Roasbeef ptal |
Returning as an integer allows a node to occur in the payment path multiple times.
joostjager
force-pushed
the
error-source-idx
branch
from
ad3ab31
to
7d1f799
Compare
cfromknecht
approved these changes
Jul 2, 2019
obfuscation_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("unable to de-obfuscate the onion failure: %v", err) | ||
| } | ||
|
|
||
| // We should understand the node from which error have been received. | ||
| if !bytes.Equal(pubKey.SerializeCompressed(), | ||
| errorPath[len(errorPath)-1].SerializeCompressed()) { | ||
| if source != len(errorPath) { |
There was a problem hiding this comment.
definitely makes these comparisons simpler 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning as an integer allows a node to occur in the payment path
multiple times.