BOLT3: RIPEMD160 -> HASH160 where appropriate #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christewart
changed the title
sstone
reviewed
Jan 17, 2019
| @@ -126,7 +126,7 @@ This output sends funds to either an HTLC-timeout transaction after the HTLC-tim | |||
| OP_DROP 2 OP_SWAP <local_htlcpubkey> 2 OP_CHECKMULTISIG | |||
| OP_ELSE | |||
| # To remote node with preimage. | |||
| OP_HASH160 <RIPEMD160(payment_hash)> OP_EQUALVERIFY | |||
| OP_HASH160 <HASH160(payment_hash)> OP_EQUALVERIFY | |||
There was a problem hiding this comment.
It's actually RIPEMD160. The trick is:
- R is a random 32 byte value chosen by the recipient
- H = sha256(R) is the payment hash used is the payment request and HTLC
- so ripemd160(H) = ripemd160(sha256(R)) = hash160(R).
This script does not check that sha256(R) == H, instead it checks that hash160(R) == ripemd160(H), which saves 12 bytes.
|
Closing. Even in the places where we could replace RIPEMD160(SHA256()) with HASH160() it's still better to be explicit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we were misusing
RIPEMD160whereHASH160should have been used in BOLT3.