Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private channel in describegraph #1037

Closed
robtex opened this issue Apr 6, 2018 · 3 comments
Closed

private channel in describegraph #1037

robtex opened this issue Apr 6, 2018 · 3 comments
Labels
beginner Issues suitable for new developers feature request Requests for new features graph P3 might get fixed, nice to have rpc Related to the RPC interface

Comments

@robtex
Copy link

robtex commented Apr 6, 2018

Background

channels that are private to the node are shown in describegraph .
can we add the private flag to describegraph so they are easier to filter out on visualizers etc?
@Roasbeef Roasbeef added rpc Related to the RPC interface graph feature request Requests for new features labels Apr 6, 2018
@halseth halseth added the beginner Issues suitable for new developers label Apr 9, 2018
@i25959341
Copy link
Contributor

Can I work on this, please?

@i25959341
Copy link
Contributor

i25959341 commented Apr 9, 2018 •
edited
Loading

What would be the best way to approach on this issue?

@halseth
Copy link
Contributor

halseth commented Apr 13, 2018

Take a look at the DescribeGraph method in the rpcserver:

lnd/rpcserver.go

Line 2482 in 86ad6d3

func (r *rpcServer) DescribeGraph(ctx context.Context,

A private edge won't have an attached AuthProof, which can be used to filter out private channels: https://github.com/lightningnetwork/lnd/blob/86ad6d318e0ba4d3e22e12baec1f37bc1471d44d/channeldb/graph.go#L1251:6

@Bluetegu Bluetegu mentioned this issue Jun 14, 2018
Merged
@Roasbeef Roasbeef added the P3 might get fixed, nice to have label Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Issues suitable for new developers feature request Requests for new features graph P3 might get fixed, nice to have rpc Related to the RPC interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Roasbeef @halseth @robtex @i25959341