Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement block-based grace period for channel announcements #305

Closed
2 tasks
Roasbeef opened this issue Aug 30, 2017 · 3 comments
Closed
2 tasks

Implement block-based grace period for channel announcements #305

Roasbeef opened this issue Aug 30, 2017 · 3 comments
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour
Milestone

Comments

@Roasbeef
Copy link
Member

Issue

Atm, as soon as a channel has reached the specified number of confirmations, then we immediately announce it to the network. Instead of the immediate announcement, we should be following the specification's prescription to wait until the funding transaction has reached at least 6 confirmations.

Steps to Completion

  • Fixing this will require decoupling the waitForFundingConfrimation method from the announcement of the channels themselves. However, by announcement we only mean broadcasting the series of channel announcement messages to the greater network.

  • As soon as the FundingLocked message is sent, we should still be immediately adding the new channel to our internal channel graph so it can become visible to the ChannelRouter during path finding.

@Roasbeef Roasbeef added discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour labels Aug 30, 2017
@Roasbeef Roasbeef added this to the v0.4-beta milestone Aug 30, 2017
@Crypt-iQ
Copy link
Collaborator

Crypt-iQ commented Sep 3, 2017

I can do this one. It is a standalone issue, right? As in it doesn't require #303 or #306 to be completed as well?

@Roasbeef
Copy link
Member Author

@Crypt-iQ it doesn't require them, but makes sense to work on the others in tandem as they touch the same part of the codebase, and slight refactors in one will likely make it easier to do the rest.

@Roasbeef
Copy link
Member Author

Closed by #411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour
Projects
None yet
Development

No branches or pull requests

2 participants