Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe channel announcement preference during channel funding workflow #306

Closed
Roasbeef opened this issue Aug 30, 2017 · 2 comments
Closed

Observe channel announcement preference during channel funding workflow #306

Roasbeef opened this issue Aug 30, 2017 · 2 comments
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour

Comments

@Roasbeef
Copy link
Member

Issue

During the funding workflow process, the initiator of the workflow signals a bit to indicate if this channel should be announced to the network or not. At this point, we don't currently observe this bit, and will instead unconditionally announce the channel to the network. Instead, we should observer the LSB of the ChannelFlags field within the OpenChannel message to determine if the channel should be announced or not.

Related to #305 as we'll also still need to insert the new channel into the channel graph so the ChannelRouter can still use the channel for path finding.
@Roasbeef Roasbeef added discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour labels Aug 30, 2017
@Roasbeef Roasbeef added this to the v0.3.1-alpha milestone Aug 30, 2017
@Crypt-iQ Crypt-iQ mentioned this issue Sep 3, 2017
Closed
2 tasks
@Crypt-iQ
Copy link
Collaborator

Crypt-iQ commented Sep 6, 2017

I can also take this since it's related to #305

@Crypt-iQ Crypt-iQ mentioned this issue Sep 10, 2017
Merged
@Crypt-iQ Crypt-iQ mentioned this issue Sep 17, 2017
Closed
@Roasbeef Roasbeef reopened this Oct 18, 2017
@Roasbeef
Copy link
Member Author

Closed by #411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs funding Related to the opening of new channels with funding transactions on the blockchain intermediate Issues suitable for developers moderately familiar with the codebase and LN p2p Code related to the peer-to-peer behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roasbeef @Crypt-iQ