Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow a single pending channel per-peer #32

Closed
Roasbeef opened this issue Aug 26, 2016 · 2 comments
Closed

Only allow a single pending channel per-peer #32

Roasbeef opened this issue Aug 26, 2016 · 2 comments
Labels
brainstorming Long term ideas/discussion/requests for feedback funding Related to the opening of new channels with funding transactions on the blockchain p2p Code related to the peer-to-peer behaviour

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Aug 26, 2016

Currently the fundingManager, and the rpcServer will happily allow either a caller or remote peer to create multiple pending channels at a time. This behavior should instead be restricted to only allow a single pending channel at a time per-peer. Such a constraint acts as a defense against a slow-loris like DoS attack wherein a peer creates hundreds of thousands of pending channels, never intending to complete the funding workflow for them.

Steps to completion:

  • the fundingMgr should reject all requests to either process or initialize a new channel funding workflow if one already exists for the targeted peer.
  • the lnwire.ErrorGeneric messagesshould be sent to the offending peer if the constraint is violated
@Roasbeef Roasbeef added brainstorming Long term ideas/discussion/requests for feedback p2p Code related to the peer-to-peer behaviour funding Related to the opening of new channels with funding transactions on the blockchain labels Aug 26, 2016
@andrewshvv
Copy link
Contributor

I will try to do this one.

Roasbeef added a commit that referenced this issue Oct 22, 2016
Only allow a single pending channel per-peer #32
@Roasbeef
Copy link
Member Author

Fixed by #36.

Closing.

ioudkerk pushed a commit to clovrlabs/wallet-lnd that referenced this issue May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming Long term ideas/discussion/requests for feedback funding Related to the opening of new channels with funding transactions on the blockchain p2p Code related to the peer-to-peer behaviour
Projects
None yet
Development

No branches or pull requests

2 participants