Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnwire: CustomMessage should use odd MessageType or feature bit #6209

Closed
Crypt-iQ opened this issue Jan 27, 2022 · 1 comment
Closed

lnwire: CustomMessage should use odd MessageType or feature bit #6209

Crypt-iQ opened this issue Jan 27, 2022 · 1 comment
Labels
p2p Code related to the peer-to-peer behaviour wire protocol Encoding of messages for the communication between nodes

Comments

@Crypt-iQ
Copy link
Collaborator

I think it is implicitly assumed that you would only send CustomMessage to a peer that also supports it. There is no negotiation, however, and so either there should be a feature bit or an odd type according to bolt 1.

Related: #5346
@Crypt-iQ Crypt-iQ added p2p Code related to the peer-to-peer behaviour wire protocol Encoding of messages for the communication between nodes labels Jan 27, 2022
@Crypt-iQ
Copy link
Collaborator Author

Nvm, it seems like this is inline with the spec for custom messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2p Code related to the peer-to-peer behaviour wire protocol Encoding of messages for the communication between nodes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Crypt-iQ