Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: drop support for sync-freelist #6837

Open
C-Otto opened this issue Aug 17, 2022 · 2 comments
Open

Proposal: drop support for sync-freelist #6837

C-Otto opened this issue Aug 17, 2022 · 2 comments
Labels
documentation Documentation changes that do not affect code behaviour

Comments

@C-Otto
Copy link
Contributor

C-Otto commented Aug 17, 2022

With lnd 0.15+ and sync-freelist=true the database grows much faster than with 0.14, causing issues once lnd runs out of free disk space and/or the database gets too large (see below). I don't understand the details behind the setting, but I think setting sync-freelist=true doesn't fix any important issue. As such, I propose to drop the flag completely, i.e. ignore sync-freelist=true if set. If this isn't feasible, I'd like to see a warning in the configuration file (https://github.com/lightningnetwork/lnd/blob/master/sample-lnd.conf).

The node ln.nicehash.com recently ran into this issue, causing lots of force-closed channels:
image
https://amboss.space/node/037659a0ac8eb3b8d0a720114efc861d3a940382dcfa1403746b4f8f6b2e8810ba

Related to #6800 #6744 #6737.

@Roasbeef Roasbeef added the documentation Documentation changes that do not affect code behaviour label Aug 17, 2022
@Roasbeef
Copy link
Member

Historically we left it in place since it allows users to make a time vs space tradeoff: syncing the freelist means more writes but a faster start up, not syncing means less writes but a slower start up.

@BhaagBoseDK
Copy link
Contributor

why does that impact

Historically we left it in place since it allows users to make a time vs space tradeoff: syncing the freelist means more writes but a faster start up, not syncing means less writes but a slower start up.

why should that impact the db growth?

Bitcoinite added a commit to Bitcoinite/RaspiBolt that referenced this issue Aug 25, 2022
The setting sync-freelist=true caused heavy bloating of the channel.db (several GB per day). Disabling this setting fixes this issue.

Related:
lightningnetwork/lnd#6800
lightningnetwork/lnd#6744
lightningnetwork/lnd#6737
lightningnetwork/lnd#6837 (comment)
VajraOfIndra pushed a commit to raspibolt/raspibolt that referenced this issue Aug 25, 2022
* Change sync-freelist to false in the lnd.conf

The setting sync-freelist=true caused heavy bloating of the channel.db (several GB per day). Disabling this setting fixes this issue.

Related:
lightningnetwork/lnd#6800
lightningnetwork/lnd#6744
lightningnetwork/lnd#6737
lightningnetwork/lnd#6837 (comment)

* remove sync-freelist=true from lnd.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes that do not affect code behaviour
Projects
None yet
Development

No branches or pull requests

3 participants