[1/?] - lnwallet: ensure that SignOutputRaw can sign w/ non-default sighash f… #7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Jan 17, 2023
Roasbeef
changed the title
Roasbeef
force-pushed
the
sign-output-raw-bug-fix
branch
from
3e0e061
to
cfe16bd
Compare
guggero
approved these changes
Jan 24, 2023
| @@ -364,7 +379,7 @@ func testTaprootSignOutputRawScriptSpend(ht *lntemp.HarnessTest, | |||
| // also be spent using the key spend path through the SignOutputRaw RPC using a | |||
| // BIP0086 key spend only commitment. | |||
| func testTaprootSignOutputRawKeySpendBip86(ht *lntemp.HarnessTest, | |||
| alice *node.HarnessNode) { | |||
| alice *node.HarnessNode, sigHashType ...txscript.SigHashType) { | |||
There was a problem hiding this comment.
An alternative would be a pointer and a nil check (instead of a len check).
Roasbeef
force-pushed
the
sign-output-raw-bug-fix
branch
2 times, most recently
from
4bb7194
to
f59766f
Compare
|
Pushed up a new version pointing to the merged btcd commit. |
…or schnorr sigs Before this commitment, we'd end up failing in `schnorr.ParseSignature` if a non-default sighash was used. To fix that, we'll slice the signature to only pass in the sig w/o the sighash flag.
Calling ht.Helper() means we'll get the proper line number if an error hapens.
…ault sighashes Without the prior commit, this test fails with: ``` rpc error: code = Unknown desc = malformed signature: too long: 65 > 64 ```
Roasbeef
force-pushed
the
sign-output-raw-bug-fix
branch
from
f59766f
to
be04709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or schnorr sigs
Before this commit, we'd end up failing in
schnorr.ParseSignatureif a non-default sighash was used. To fix that, we'll slice the signature to only pass in the sig w/o the sighash flag.]