Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/?] - lnwallet: ensure that SignOutputRaw can sign w/ non-default sighash f… #7332

Merged
merged 5 commits into from
Jan 26, 2023
Merged

[1/?] - lnwallet: ensure that SignOutputRaw can sign w/ non-default sighash f… #7332

merged 5 commits into from
Jan 26, 2023

Commits on Jan 25, 2023

  1. build: update to latest version of btcd

    @Roasbeef
    Roasbeef committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9b422ac View commit details
    Browse the repository at this point in the history

  2. lnwallet: ensure that SignOutputRaw can sign w/ non-default sighash f… 

    …or schnorr sigs

Before this commitment, we'd end up failing in `schnorr.ParseSignature`
if a non-default sighash was used. To fix that, we'll slice the
signature to only pass in the sig w/o the sighash flag.
    @Roasbeef
    Roasbeef committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    843c62b View commit details
    Browse the repository at this point in the history

  3. lntest/itest: make publishTxAndConfirmSweep a test helper 

    Calling ht.Helper() means we'll get the proper line number if an error
hapens.
    @Roasbeef
    Roasbeef committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8ab598e View commit details
    Browse the repository at this point in the history

  4. lntest/itest: update taproot signing itest to use default and non-def… 

    …ault sighashes

Without the prior commit, this test fails with:
```
rpc error: code = Unknown desc = malformed signature: too long: 65 > 64
```
    @Roasbeef
    Roasbeef committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    3d8f284 View commit details
    Browse the repository at this point in the history

  5. docs/release-notes: add entry for taproot sighash bug fix

    @Roasbeef
    Roasbeef committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    be04709 View commit details
    Browse the repository at this point in the history