Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: support multiple outgoing channel IDs in lncli #7915

Closed
The34Goon opened this issue Aug 23, 2023 · 6 comments · Fixed by #8261
Closed

[feature]: support multiple outgoing channel IDs in lncli #7915

The34Goon opened this issue Aug 23, 2023 · 6 comments · Fixed by #8261
Assignees
Labels
enhancement Improvements to existing features / behaviour lncli
Milestone

Comments

@The34Goon
Copy link

I want to pay an invoice using either all channels except A B C or define them X Y Z

lncli payinvoice --timeout 20m --fee_limit 35 --outgoing_chan_id XXX YYY ZZZ --pay_req
results in only XXX being used.

lncli payinvoice --timeout 20m --fee_limit 35 —outgoing_chan_id XXX —outgoing_chan_id YYY —outgoing_chan_id ZZZ --pay_req
results in only ZZZ being used.

response when using the --outgoing_chan_ids flag described in api-docs
[lncli] flag provided but not defined: -outgoing_chan_ids

LND_0.16.4-beta

what am I missing?

@The34Goon The34Goon added the enhancement Improvements to existing features / behaviour label Aug 23, 2023
@alexbosworth
Copy link
Contributor

The API docs don't describe LNCLI, they describe the API that LNCLI uses

@guggero guggero changed the title LNCLI payinvoice from X, Y, Z as first hop [feature]: [feature]: support multiple outgoing channel IDs in lncli Aug 28, 2023
@guggero
Copy link
Collaborator

guggero commented Aug 28, 2023

As suspected, the command line only takes a single parameter and adds it to the outgoing_chan_ids of the RPC call: https://github.com/lightningnetwork/lnd/blob/master/cmd/lncli/cmd_payments.go#L425

Probably the reason for it is that the CLI library doesn't offer a Int64SliceFlag, so we'd need to use a string slice flag and parse it manually.

For your use case it might be simpler to just create a small NodeJS or Python wrapper script that feeds the params into an RPC call.

@markettes
Copy link
Contributor

May I take this one?

@markettes
Copy link
Contributor

markettes commented Dec 7, 2023

By the way, for the query routes call, I would say we need to change it to accept the same as the payment, an array of strings for the outgoing_chan_id. Let me know if I can fix it with this issue. 😄

@markettes
Copy link
Contributor

Solved here:
#8261

@saubyk
Copy link
Collaborator

saubyk commented Dec 8, 2023

reopening as the pr is not merged yet

@saubyk saubyk reopened this Dec 8, 2023
@saubyk saubyk linked a pull request Dec 8, 2023 that will close this issue
8 tasks
@saubyk saubyk added the lncli label Dec 8, 2023
@saubyk saubyk added this to the v0.18.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour lncli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants