Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple outgoing channel ids in payments #8261

Merged

Conversation

markettes
Copy link
Contributor

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

馃摑 Please see our Contribution Guidelines for further guidance.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy diff, nice enhancement, one question about the new CLI API, but will confirm before final merge.

cmd/lncli/cmd_payments.go Show resolved Hide resolved
@saubyk saubyk linked an issue Dec 8, 2023 that may be closed by this pull request
@saubyk saubyk added the lncli label Dec 8, 2023
@saubyk saubyk added this to the v0.18.0 milestone Dec 8, 2023
@markettes markettes force-pushed the lncli-multiple-outgoing-channels branch from 02b3ffb to 1250e0e Compare December 18, 2023 08:29
@markettes markettes force-pushed the lncli-multiple-outgoing-channels branch from 0320999 to ea9a780 Compare December 18, 2023 09:27
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 馃帀

@guggero guggero merged commit 0df507e into lightningnetwork:master Dec 18, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: support multiple outgoing channel IDs in lncli
4 participants