config: increase max funding and payment amount 60x under Litecoin #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
May 15, 2018
wpaulino
changed the title
wpaulino
force-pushed
the
bump-ltc-limits
branch
2 times, most recently
from
f90cba3
to
3adc923
Compare
cfromknecht
suggested changes
May 21, 2018
fundingmanager.go
Outdated
| // primary chain due to the price difference. | ||
| // | ||
| // TODO(roasbeef): add command line param to modify | ||
| maxFundingAmount = btcutil.Amount(1 << 24) |
There was a problem hiding this comment.
IMO it'd be preferable to have enumerate both constants, maxBtcFundingAmount and maxLtcFundingAmount similar to how we have for the other constraints.
If we want to make this easy to modify in the future, we can also define something like btcToLtcConversionRate = 60 and compute ltc constants at compile time
config.go
Outdated
| registeredChains.RegisterPrimaryChain(litecoinChain) | ||
| maxFundingAmount *= 60 | ||
| maxPaymentMSat *= 60 |
There was a problem hiding this comment.
Instead of doing this scaling here, we can set local maxFundingAmount or maxPaymentMSat vars based on which chain is active
wpaulino
force-pushed
the
bump-ltc-limits
branch
3 times, most recently
from
13cf1f1
to
0b4287e
Compare
cfromknecht
reviewed
May 24, 2018
fundingmanager.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| // maxBtcFundingAmount is a soft-limit of the maximum channel size |
There was a problem hiding this comment.
s/maxBtcFundingAmount/maxFundingAmount/
Roasbeef
requested changes
May 25, 2018
fundingmanager.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| // maxBtcFundingAmount is a soft-limit of the maximum channel size |
fundingmanager.go
Outdated
| // Protocol. This limit is defined in BOLT-0002, and serves as an | ||
| // initial precautionary limit while implementations are battle tested | ||
| // in the real world. | ||
| maxBtcFundingAmount = btcutil.Amount(1 << 24) |
There was a problem hiding this comment.
While we're here, this should actually be -1 at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.