channeldb: modify updateChanBucket to no longer auto-create buckets #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we modify the existing updateChanBucket function to no longer auto-create buckets if they don't exist. We do this in order to fix a class of bug that could arise wherein after a channel has actually be closed (and the parent buckets removed) a method that mutates the channel state is called, which then re-creates the relevant set of buckets. As a result, subsequent calls to any RPCs which need to read all the channels will fail as most of the fields won't actually be populated. After this commit, the fullSync method is the only one that's able to create the full bucket hierarchy.
cfromknecht
suggested changes
May 23, 2018
channeldb/channel.go
Outdated
| // level, creating the bucket (if it doesn't exist), for this channel | ||
| // itself. | ||
| var chanPointBuf bytes.Buffer | ||
| chanPointBuf.Grow(outPointSize) |
There was a problem hiding this comment.
This isn't necessary since outPointSize is less than 64
There was a problem hiding this comment.
Fixed. Also remove other instances in this file.
This optimization isn't needed as a bytes.Buffer already comes pre-allocated with 64-bytes as a fast path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we modify the existing updateChanBucket function to no
longer auto-create buckets if they don't exist. We do this in order to
fix a class of bug that could arise wherein after a channel has actually
be closed (and the parent buckets removed) a method that mutates the
channel state is called, which then re-creates the relevant set of
buckets. As a result, subsequent calls to any RPCs which need to read
all the channels will fail as most of the fields won't actually be
populated.
After this commit, the fullSync method is the only one that's able to
create the full bucket hierarchy.