[bugfix] lnwallet/channel: use FullySynced to check chanSync special case #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
chain-height-resend-commitsig
branch
from
48704e6
to
5dcc599
Compare
We check if the channel is FullySynced instead of comparing the local and remote commit chain heights, as the heights might not be in sync. Instead we call FullySynced which recently was modified to use compare the message indexes instead, which is _should_ really be in sync between the chains. The test TestChanSyncOweRevocationAndCommitForceTransition is altered to ensure the two chains at different heights before the test is started, to trigger the case that would previously fail to resend the commitment signature.
halseth
force-pushed
the
chain-height-resend-commitsig
branch
from
5dcc599
to
07629e5
Compare
Roasbeef
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check if the channel is FullySynced instead of comparing the local
and remote commit chain heights, as the heights might not be in sync.
Instead we call FullySynced which recently was modified to use compare
the message indexes instead, which is should really be in sync between
the chains.
The test TestChanSyncOweRevocationAndCommitForceTransition is altered to
ensure the two chains at different heights before the test is started, to
trigger the case that would previously fail to resend the commitment
signature.