channeldb: don't reject duplicate waiting proofs #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we modify the waiting proof slightly to acept dupliacte waiting proofs, rather than reject them. Otherwise, it's possible that the remote node first sends us their half of the waiting proof (before we do), we write that to disk, then upon restart, we'll try to add it again, but be rejected by the system. Fixes lightningnetwork#1315.
halseth
approved these changes
Jun 5, 2018
| @@ -56,10 +56,6 @@ func NewWaitingProofStore(db *DB) (*WaitingProofStore, error) { | |||
|
|
|||
| // Add adds new waiting proof in the storage. | |||
| func (s *WaitingProofStore) Add(proof *WaitingProof) error { | |||
| if _, ok := s.cache[proof.Key()]; ok { | |||
| return ErrWaitingProofAlreadyExist | |||
There was a problem hiding this comment.
nit: definition of ErrWaitingProofAlreadyExist can now be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we modify the waiting proof slightly to acept dupliacte
waiting proofs, rather than reject them. Otherwise, it's possible that
the remote node first sends us their half of the waiting proof (before
we do), we write that to disk, then upon restart, we'll try to add it
again, but be rejected by the system.
Fixes #1315.