test+server: finalize inbound/outbound fixes, update itests to account for fixes #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
server-fixes-itest-stability
branch
2 times, most recently
from
e62f862
to
18de558
Compare
Roasbeef
force-pushed
the
server-fixes-itest-stability
branch
from
d1e0a88
to
9d1d1b7
Compare
In this commit, we modify the look up for inbound peers to ensure that we connect to the "freshest" address until we need to execute the peerTerminationWatcher. We do this as it's possible for a channel to be created by the remote peer during our session. If we don't query for the node's address at the latest point, then we'll miss this new node announcement for the node.
…a scheduled callback In this commit, we ensure that if we're already ignoring a connection, then we also ignore the pending persistent connection request. Otherwise, we'll move to accept the replaced connection, but then continue to attempt connection requests.
…nection logic With the recent bug fixes in the peer connection, it's no longer the case that just disconnecting a certain peer causes it to no longer connect to the other. As a result, we now shutdown Alice to ensure no reconnection occurs. We'll then later restart alice when we restart dave.
In this commit, we finish the fix for the inbound/outbound peer bool in the server. The prior commit forgot to also flip the inbound/output maps in Inbound/Outbound peer connected. As a result, the checks were incorrect and could cause lnd to refuse to accept any more inbound connections in the case of a concurrent connection attempt.
Roasbeef
force-pushed
the
server-fixes-itest-stability
branch
from
9d1d1b7
to
418ecba
Compare
halseth
previously approved these changes
Jun 11, 2018
|
As the PR is incomplete, once #1351 is finalized, we should make a joint PR to confirm it resolves the current issues. |
Roasbeef
force-pushed
the
server-fixes-itest-stability
branch
from
1549677
to
418ecba
Compare
In this commit, we fix the logging when adding new gossip syncers. The old log would log the byte array, rather than the byte slice. We fix this by slicing before logging.
…Link In this commit, we modify the interfaceIndex to no longer key the second level of the index by the ChannelLink. Instead, we'll use the chan ID as it's a stable identifier, unlike a reference to an interface.
In this commit, we fix a bug in the way we handle removing items from the interfaceIndex. Before this commit, we would delete all items items with the target public key that of the peer that owns the link being removed. However, this is incorrect as the peer may have other links sill active. In this commit, we fix this by first only deleting the link from the peer's index, and then checking to see if the index is empty after this deletion. Only if so do we delete the index for the peer all together.
In this commit we fix an existing bug which could cause internal state inconsistency between then switch, funding manager, and the peer. Before this commit, we would _always_ add a new channel to the channelManager. However, due to recent logic, it may be the case that this isn't the channel that will ultimately reside in the link. As a result, we would be unable to process incoming FundingLocked messages properly, as we would mutate the incorrect channel in memory. We remedy this by moving the inserting of the new channel into the activeChannels map until the end of the loadActiveChannels method, where we know that this will be the link that persists.
Roasbeef
force-pushed
the
server-fixes-itest-stability
branch
from
7c5eebf
to
e60d2b7
Compare
|
We're green now 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1337.
Fixes #1360.
Fixes #1361.
Fixes #1365.
Fixes #1366.