Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
multi: send a channel update with disabled flag set on channel close #1387
Nice! Will be good to get these changes in to help quell lingering routing failures while channels are closing. Did an initial pass to familiarize myself w/ the PR
Jun 30, 2018
I'm wondering if we can send out disable messages even more aggressively. Could we disable the channel every time it is removed from the switch (as this is the point it cannot route payments anymore), and enable it when it is added?
Not sure if this would lead to unnecessary spam on them network, but it would also help by disabling channels for offline nodes. Or would this be leak any sensitive information? (I don't think so, as it is fairly easy to ping a node to see if it's offline anyway).
Based on the recent convo in #1605, I'm warming up a bit more to sending it out each time something disconnects from the link itself, as it'll help to reduce routing failures over all. Also Johan brings up a good point that one can simply attempt to connect to nodes in order to get this type of reachability information.
The one worry is the level of spam really that this can generate if a peer is very flappy for w/e reason. On our send, I think we can just enforce stricter controls on how often we send this out, in addition to the trickle logic already present in the gossiper itself.