Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htlcswitch/link: correct bias in fee update backoff #1482

Merged
merged 3 commits into from
Jul 4, 2018
Merged

htlcswitch/link: correct bias in fee update backoff #1482

merged 3 commits into from
Jul 4, 2018

Commits on Jun 30, 2018

  1. htlcswitch/link: correct bias in fee update backoff 

    This commit corrects the distribution used to
schedule a link's randomized backoff for fee
updates. Currently, our algorithm biases the
lowest value in the range, with probability
equal to lower/upper, or the ratio of the lower
bound to the upper. This distribution is skewed
more heavily as lower approaches upper.

The solution is to sample a random value in the
range upper-lower, then add this to our lower
bound. The effect is a uniformly distributed
timeout in [lower, upper).
    @cfromknecht
    cfromknecht committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    5fa8124 View commit details
    Browse the repository at this point in the history

  2. htlcswitch/link_test: use realistic link timeouts

    @cfromknecht
    cfromknecht committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    10ecf23 View commit details
    Browse the repository at this point in the history

  3. htlcswitch/test_utils: use realistic link timeouts

    @cfromknecht
    cfromknecht committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    12f74f7 View commit details
    Browse the repository at this point in the history