docker: change container golang version; fix readme #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndrewSamokhvalov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @michielbdejong and @Roasbeef to be potential reviewers. |
Roasbeef
reviewed
Mar 22, 2017
| @@ -83,17 +84,6 @@ $ docker-compose run btcctl generate 400 | |||
| $ docker-compose run btcctl getblockchaininfo | grep -A 1 segwit | |||
| ``` | |||
|
|
|||
| Now we have `btcd` running and some amount of bitcoins mined to the `Alice` | |||
There was a problem hiding this comment.
Why was this section removed? IIRC, it can only be removed once we switch to using the setminingaddr command.
There was a problem hiding this comment.
We talked offline, and Andrew pointed out that since we now auto-reconnect to btcd within btcwallet, this is no longer needed.
|
Changes Unknown when pulling 761b046 on AndrewSamokhvalov:fix_docker_build into ** on lightningnetwork:master**. |
Roasbeef
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #164