-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature route to self #1685
Conversation
* Added ability to find paths to self * Added unit tests for self routing This allows queryroutes to find a route to self for manual balancing of channels. And will lays the grounds for rebalance command, as well as auto-balancing channels.
Formatting.
* Fixed infinite loop and formatting Fixed infinite loop between FindPath and FindPaths
Fixed bad interaction between FindPath and FindPaths that wasn't previously detected in unit testing, which caused an infinite loop between them. |
Blocked by #1321. |
In my opinion, the implementation as it is now contains assumptions that may not be true leading to suboptimal results. In particular the determination of the "middle node". I am not sure either whether this is optimal performance-wise with the recursive I think the plan with a virtual self node as outlined in #1652 is more solid. Don't want to reopen the discussion, but just drop the reference for any reviewers to consider. |
You don't have to find the "optimum" path on the first try, that's what "FindPaths" does. |
Needs to have the code pieces moved around to compensate for the reverse pathfinding introduced in 1321. |
Had to re-write to be compatible with new pathfind algo. |
Added ability to find paths to self
Added unit tests for self routing
This allows queryroutes to find a route to self for manual balancing of channels.
And will lays the grounds for rebalance command, as well as auto-balancing channels.