New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: show inactive channels in GetInfo #1782

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@xsb
Contributor

xsb commented Aug 24, 2018

Adds the num_inactive_channels field in the response of the GetInfo gRPC call. Inactive channels is calculated substracting the number of active channels to the sum of all currently open channels.

Fixes #1779

@xsb

This comment has been minimized.

Contributor

xsb commented Aug 24, 2018

Output tested using lncli but I don't know yet how to get into a scenario in which there are inactive channels. If someone can help that would be super cool.

Also I am not exactly sure if I am messing up with gRPC in some way so if that's the case let me know.

@xsb xsb force-pushed the xsb:getinfo-inactive-channels branch from 4d8bcd6 to a0401f7 Aug 27, 2018

Show resolved Hide resolved lnrpc/rpc.proto Outdated

@halseth halseth added this to the 0.5.1 milestone Aug 28, 2018

@xsb xsb force-pushed the xsb:getinfo-inactive-channels branch from ff7986f to 5e3b2a6 Aug 28, 2018

@xsb xsb force-pushed the xsb:getinfo-inactive-channels branch from 5e3b2a6 to ca687a2 Sep 17, 2018

@xsb

This comment has been minimized.

Contributor

xsb commented Sep 17, 2018

rebased

@halseth halseth modified the milestones: 0.5.1, 0.5.2 Sep 20, 2018

@halseth

This comment has been minimized.

Collaborator

halseth commented Nov 1, 2018

Needs a rebase! Otherwise LGTM 👍

@xsb xsb force-pushed the xsb:getinfo-inactive-channels branch from ca687a2 to 9db05b7 Nov 3, 2018

@xsb

This comment has been minimized.

Contributor

xsb commented Nov 4, 2018

@halseth rebased. I also squashed the commits you mentioned in the comment.

@cfromknecht

LGTM 👍Thanks @xsb, this is definitely a useful addition!

@xsb xsb force-pushed the xsb:getinfo-inactive-channels branch from 9db05b7 to ca9f572 Nov 5, 2018

@xsb

This comment has been minimized.

Contributor

xsb commented Nov 5, 2018

rebased again, rpc.pb.go was updated on master

@halseth

halseth approved these changes Nov 6, 2018

@halseth

halseth approved these changes Nov 6, 2018

Looks good! 💯

@cfromknecht

LGTM! 🚀thanks @xsb!

@halseth halseth merged commit 3ff6055 into lightningnetwork:master Nov 7, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 55.835%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment