rpcserver: show inactive channels in GetInfo #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Output tested using Also I am not exactly sure if I am messing up with gRPC in some way so if that's the case let me know. |
3 tasks
halseth
suggested changes
Aug 28, 2018
Roasbeef
added
rpc
|
rebased |
halseth
added
the
needs testing
|
Needs a rebase! Otherwise LGTM 👍 |
halseth
reviewed
Nov 1, 2018
|
@halseth rebased. I also squashed the commits you mentioned in the comment. |
cfromknecht
previously approved these changes
Nov 5, 2018
|
rebased again, rpc.pb.go was updated on master |
halseth
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
num_inactive_channelsfield in the response of theGetInfogRPC call. Inactive channels is calculated substracting the number of active channels to the sum of all currently open channels.Fixes #1779