Option to disable incoming push amounts on channel opening #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodentrabies
force-pushed
the
no-incoming-push-amounts-option
branch
from
5f8e807
to
975e9a3
Compare
halseth
suggested changes
Oct 11, 2018
rodentrabies
force-pushed
the
no-incoming-push-amounts-option
branch
from
975e9a3
to
b124190
Compare
|
I'm not quite sure about adding another error type ( |
Roasbeef
added
funding
halseth
suggested changes
Oct 29, 2018
rodentrabies
force-pushed
the
no-incoming-push-amounts-option
branch
from
b124190
to
3a8e738
Compare
This is useful for merchant-side prevention of accidental pushes during channel opening.
rodentrabies
force-pushed
the
no-incoming-push-amounts-option
branch
from
3a8e738
to
6f3adcd
Compare
cfromknecht
reviewed
Nov 11, 2018
| cfg.RejectPush = true | ||
| defer func() { | ||
| tearDownFundingManagers(t, alice, bob) | ||
| cfg.RejectPush = rejectPush |
There was a problem hiding this comment.
just leaving a note that this could be lead to a race condition in the unit tests if other tests are reading from cfg in parallel. we can revisit if it surfaces
There was a problem hiding this comment.
Hm yeah, value should probably be copied to the fundingMgr config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal in #1884.
Progress:
Fixes #1884.