New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htlcswitch+routing: implement expiry_too_far failure #2051

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@joostjager
Collaborator

joostjager commented Oct 15, 2018

We add a check to HtlcSatifiesPolicy to verify that the time lock for the outgoing htlc that is requested in the onion packet isn't too far in the future.

Without this check, anyone could force an unreasonably long time lock on the forwarding node.

Fixes #2049

@joostjager joostjager force-pushed the joostjager:cltv-too-far branch from 6d8750b to 350c7c3 Oct 15, 2018

htlcswitch+routing: implement expiry_too_far failure
In this commit we add a check to HtlcSatifiesPolicy to verify that the
time lock for the outgoing htlc that is requested in the onion packet
isn't too far in the future.

Without this check, anyone could force an unreasonably long time lock on
the forwarding node.

@joostjager joostjager force-pushed the joostjager:cltv-too-far branch from 350c7c3 to 1d97cf1 Oct 15, 2018

@Roasbeef

LGTM 🎡

@Roasbeef Roasbeef merged commit ab12184 into lightningnetwork:master Oct 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 55.228%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment