Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fundingmanager: rejects funding requests with number of confirmations too large #2275

Merged
merged 7 commits into from Jan 15, 2019
Merged

fundingmanager: rejects funding requests with number of confirmations too large #2275

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d51114
chainntnfs/txnotifier: define ReorgSafetyLimit as 144 blocks
wpaulino Dec 5, 2018
7239e04
chainntnfs: initialize TxNotifier with new ReorgSafetyLimit
wpaulino Dec 5, 2018
fd2bfaa
chainntnfs: add TestTxNotifierMaxConfs
wpaulino Dec 5, 2018
5be8f08
chainntnfs/txnotiifer: define MaxNumConfs supported as ReorgSafetyLimit
wpaulino Dec 5, 2018
b951f06
multi: move CsvDelay into ChannelConstraints
wpaulino Dec 10, 2018
71410f6
lnwallet+fundingmanager: use ChannelConstraints struct with CommitCon…
wpaulino Dec 10, 2018
4f953af
lnwallet+fundingmanager: enforce max MinAcceptDepth within funding pr…
wpaulino Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions chainntnfs/txnotifier.go
View file
Open in desktop
Expand Up @@ -17,6 +17,10 @@ const (
// handled correctly. The average number of blocks in a day is a
// reasonable value to use.
ReorgSafetyLimit = 144

// MaxNumConfs is the maximum number of confirmations that can be
// requested on a transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would add the rationale for setting it equal to the comment.

MaxNumConfs = ReorgSafetyLimit
wpaulino marked this conversation as resolved.
Show resolved Hide resolved
)

var (
Expand Down