multi: replace per channel sigPool with global daemon level sigPool #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
added
wallet
wpaulino
reviewed
Dec 15, 2018
| @@ -1467,18 +1459,6 @@ func (lc *LightningChannel) createStateHintObfuscator() { | |||
| } | |||
| } | |||
|
|
|||
| // Stop gracefully shuts down any active goroutines spawned by the | |||
| // LightningChannel during regular duties. | |||
| func (lc *LightningChannel) Stop() { | |||
There was a problem hiding this comment.
Nit: looks like we can also remove the now unused shutdown and quit members.
|
breacharbiter_test doesn't compile atm |
In this commit, we remove the per channel `sigPool` within the `lnwallet.LightningChannel` struct. With this change, we ensure that as the number of channels grows, the number of gouroutines idling in the sigPool stays constant. It's the case that currently on the daemon, most channels are likely inactive, with only a hand full actually consistently carrying out channel updates. As a result, this change should reduce the amount of idle CPU usage, as we have less active goroutines in select loops. In order to make this change, the `SigPool` itself has been publicly exported such that outside callers can make a `SigPool` and pass it into newly created channels. Since the sig pool now lives outside the channel, we were also able to do away with the Stop() method on the channel all together. Finally, the server is the sub-system that is currently responsible for managing the `SigPool` within lnd.
Roasbeef
force-pushed
the
global-sig-pool
branch
from
5086c91
to
fa160f5
Compare
|
Fixed, PTAL! |
wpaulino
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we remove the per channel
sigPoolwithin thelnwallet.LightningChannelstruct. With this change, we ensure that asthe number of channels grows, the number of gouroutines idling in the
sigPool stays constant. It's the case that currently on the daemon, most
channels are likely inactive, with only a hand full actually
consistently carrying out channel updates. As a result, this change
should reduce the amount of idle CPU usage, as we have less active
goroutines in select loops.
In order to make this change, the
SigPoolitself has been publiclyexported such that outside callers can make a
SigPooland pass it intonewly created channels. Since the sig pool now lives outside the
channel, we were also able to do away with the Stop() method on the
channel all together.
Finally, the server is the sub-system that is currently responsible for
managing the
SigPoolwithin lnd.