Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnwire+peer: fully validate node aliases on the wire, don't d/c due to invalid aliases #2412

Merged
merged 3 commits into from Jan 8, 2019
Merged

lnwire+peer: fully validate node aliases on the wire, don't d/c due to invalid aliases #2412

merged 3 commits into from Jan 8, 2019

Commits on Jan 7, 2019

  1. lnwire: when reading node aliases, properly check validity 

    In this commit, we ensure that when we read node aliases from the wire,
we ensure that they're valid. Before this commit, we would read the raw
bytes without checking for validity which could result in us writing in
invalid node alias to disk. We've fixed this, and also updated the
quickcheck tests to generate valid strings.
    @Roasbeef
    Roasbeef committed Jan 7, 2019
    Copy the full SHA
    0b10f4c View commit details
    Browse the repository at this point in the history

  2. lnwire: add test cases for node alias validation

    @Roasbeef
    Roasbeef committed Jan 7, 2019
    Copy the full SHA
    1821773 View commit details
    Browse the repository at this point in the history

  3. peer: don't d/c on invalid node alias

    @Roasbeef
    Roasbeef committed Jan 7, 2019
    Copy the full SHA
    a49e39d View commit details
    Browse the repository at this point in the history