lnwire: Adjust Stringer to standard chan id format

[alexbosworth]

This would adjust logging output to use a more easily selectable short channel id components string

[halseth]

LGTM 👍

[cfromknecht]

Do we want to wait on merging until lncli can handle parsing of this format as well? For example, users who grab sids from logs and look them up via will need to manually replace the x’s with colons when querying

[cfromknecht]

Oops!

[cfromknecht]

LGTM! 🎸

[Roasbeef]

Would say we should wait on this until we update lncli to accept this format and convert it to the regular format. We can even just keep our RPCs as is for time being, and expect that lncli or the client is able to convert the short channel ID properly.

[guggero]

What's the dependency for this? What needs to be changed in lncli to get this in?

[Roasbeef]

What's the dependency for this? What needs to be changed in lncli to get this in?

I don't think anything does? Given that lncli always accepts the integer version since it's generally easier to copy/paste. We could also log the integer version in parens or something in this new stringer.

[cfromknecht]

What's the dependency for this? What needs to be changed in lncli to get this in?

Ideally all of our commands in lncli where a channelid is accepted we also accept the new format. Otherwise users will need to convert back into the integer format, e.g. when trying to use getchaninfo.