Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect links in Readme file #267

Closed
wants to merge 4 commits into from

Conversation

funyug
Copy link
Contributor

@funyug funyug commented Aug 26, 2017

The links to api.lightning.community and dev.lightning.community in the readme file are currently relative urls without http:// which points to a url on github.com which is wrong.

This PR updates both the links.

@mention-bot
Copy link

@funyug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Roasbeef, @AndrewSamokhvalov and @mtlynch to be potential reviewers.

Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

Roasbeef
Roasbeef previously approved these changes Sep 14, 2017
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤹‍♂️

Once you rebase this to the latest master to resolve the minor conflict. We'll get this merged!

@Roasbeef
Copy link
Member

Merged in as 90d13cf.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants