Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: disable route cache for non-default requests #2945

Closed

Conversation

joostjager
Copy link
Collaborator

@joostjager joostjager commented Apr 12, 2019

The PR attempts to fix the following problem reported by a user:

Hi, I'm trying the new queryroutes command and I'm using it via grpc (python). I'm seeing weird time-dependent behavior. Specifically I'm trying to get routes from queryroutes, try the route and after failure putting the failed channel on the blacklist. However, if I request then another path applying the channel blacklist, I'm getting back the same route as before. With the same code, only by putting a sleep statement, sometimes I get a different path (but not always), where the blacklisted channel was excluded. Is there some sort of caching active? Thank you!

This fix doesn't address the changing bandwidth hints which may still cause routes to be returned of which we could already know that they'd fail.

@joostjager joostjager changed the title routing: disable route cache routing: disable route cache for non-default requestes Apr 12, 2019
@joostjager joostjager changed the title routing: disable route cache for non-default requestes routing: disable route cache for non-default requests Apr 12, 2019
@joostjager
Copy link
Collaborator Author

I think it is better to remove the route cache alltogether: #2950

@joostjager joostjager closed this Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant