discovery: prevent broadcast of anns received during initial graph sync #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
added
enhancement
Roasbeef
approved these changes
Aug 5, 2019
discovery/gossiper.go
Outdated
| emittedAnnouncements..., | ||
| ) | ||
| } | ||
| announcements.AddMsgs( |
There was a problem hiding this comment.
Why omit the check? It lets us avoid grabbing a mutex FWIW.
wpaulino
force-pushed
the
prevent-initial-gossip-sync-broadcast
branch
2 times, most recently
from
c87ec0f
to
cdcba46
Compare
|
Can be rebased now! |
wpaulino
force-pushed
the
prevent-initial-gossip-sync-broadcast
branch
from
cdcba46
to
442e58f
Compare
|
Rebased |
cfromknecht
reviewed
Aug 21, 2019
There's no need to broadcast these as we assume that online nodes have already received them. For nodes that were offline, they should receive them as part of their initial graph sync.
wpaulino
force-pushed
the
prevent-initial-gossip-sync-broadcast
branch
from
442e58f
to
e15e524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to broadcast these as we assume that online nodes have already received them. For nodes that were offline, they should receive them as part of their initial graph sync.
Depends on #3355.