Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: prevent broadcast of anns received during initial graph sync #3366

Conversation

@wpaulino
Copy link
Collaborator

@wpaulino wpaulino commented Aug 1, 2019

There's no need to broadcast these as we assume that online nodes have already received them. For nodes that were offline, they should receive them as part of their initial graph sync.

Depends on #3355.

Copy link
Member

@Roasbeef Roasbeef left a comment

LGTM 🎾

Will kick off a few new initial bootstrap test runs on testnet to confirm that we no longer broadcast externally.

emittedAnnouncements...,
)
}
announcements.AddMsgs(
Copy link
Member

@Roasbeef Roasbeef Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why omit the check? It lets us avoid grabbing a mutex FWIW.

Copy link
Collaborator Author

@wpaulino wpaulino Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed.

@wpaulino wpaulino force-pushed the prevent-initial-gossip-sync-broadcast branch 2 times, most recently from c87ec0f to cdcba46 Aug 7, 2019
@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Aug 13, 2019

Can be rebased now!

@wpaulino wpaulino force-pushed the prevent-initial-gossip-sync-broadcast branch from cdcba46 to 442e58f Aug 13, 2019
@wpaulino
Copy link
Collaborator Author

@wpaulino wpaulino commented Aug 13, 2019

Rebased

@wpaulino wpaulino requested review from cfromknecht and removed request for halseth Aug 21, 2019
There's no need to broadcast these as we assume that online nodes have
already received them. For nodes that were offline, they should receive
them as part of their initial graph sync.
@wpaulino wpaulino force-pushed the prevent-initial-gossip-sync-broadcast branch from 442e58f to e15e524 Aug 21, 2019
@wpaulino wpaulino requested a review from cfromknecht Aug 21, 2019
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM 🔥

@wpaulino wpaulino merged commit c4ba557 into lightningnetwork:master Aug 21, 2019
1 of 2 checks passed
@wpaulino wpaulino deleted the prevent-initial-gossip-sync-broadcast branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants