Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: prevent broadcast of anns received during initial graph sync #3366

Conversation

@wpaulino
Copy link
Collaborator

commented Aug 1, 2019

There's no need to broadcast these as we assume that online nodes have already received them. For nodes that were offline, they should receive them as part of their initial graph sync.

Depends on #3355.

@wpaulino wpaulino requested a review from halseth as a code owner Aug 1, 2019
@wpaulino wpaulino added this to the 0.8.0 milestone Aug 1, 2019
Copy link
Member

left a comment

LGTM 🎾

Will kick off a few new initial bootstrap test runs on testnet to confirm that we no longer broadcast externally.

emittedAnnouncements...,
)
}
announcements.AddMsgs(

This comment has been minimized.

Copy link
@Roasbeef

Roasbeef Aug 5, 2019

Member

Why omit the check? It lets us avoid grabbing a mutex FWIW.

This comment has been minimized.

Copy link
@wpaulino

wpaulino Aug 6, 2019

Author Collaborator

Good point, fixed.

@wpaulino wpaulino force-pushed the wpaulino:prevent-initial-gossip-sync-broadcast branch 2 times, most recently from c87ec0f to cdcba46 Aug 6, 2019
@Roasbeef

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Can be rebased now!

@wpaulino wpaulino force-pushed the wpaulino:prevent-initial-gossip-sync-broadcast branch from cdcba46 to 442e58f Aug 13, 2019
@wpaulino

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 13, 2019

Rebased

@wpaulino wpaulino requested review from cfromknecht and removed request for halseth Aug 21, 2019
There's no need to broadcast these as we assume that online nodes have
already received them. For nodes that were offline, they should receive
them as part of their initial graph sync.
@wpaulino wpaulino force-pushed the wpaulino:prevent-initial-gossip-sync-broadcast branch from 442e58f to e15e524 Aug 21, 2019
@wpaulino wpaulino requested a review from cfromknecht Aug 21, 2019
Copy link
Collaborator

left a comment

LGTM 🔥

@wpaulino wpaulino merged commit c4ba557 into lightningnetwork:master Aug 21, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.02%) to 61.006%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wpaulino wpaulino deleted the wpaulino:prevent-initial-gossip-sync-broadcast branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.