Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump btcsuite and neutrino dependencies to latest tagged versions #3649

Merged
merged 2 commits into from Nov 15, 2019

Conversation

wpaulino
Copy link
Contributor

@wpaulino wpaulino commented Oct 30, 2019

The btcwallet update includes some edge-case wallet bug fixes and an
optimization on ZMQ connections for bitcoind backends.

The btcd update allows for compatibility with bitcoind v0.19.0 backends.

Fixes #2961.
Fixes #3412
Fixes #3625.
Fixes #3640.

@joostjager joostjager added this to WIP in v0.9.0-beta via automation Oct 30, 2019
@joostjager joostjager added this to the 0.9.0 milestone Oct 30, 2019
@joostjager joostjager moved this from WIP to Needs Review in v0.9.0-beta Oct 30, 2019
@cfromknecht
Copy link
Contributor

also change build script to pull in bitcoind 0.19?

@wpaulino
Copy link
Contributor Author

also change build script to pull in bitcoind 0.19?

Definitely, I plan to do so once Travis is restored. I'll push another commit to pull 0.19.0 so we can have both builds (0.18.1 and 0.19.0) show under the same PR.

@Roasbeef Roasbeef added bitcoind Bitcoin Core backend P2 should be fixed if one has time labels Nov 9, 2019
@Roasbeef
Copy link
Member

Roasbeef commented Nov 9, 2019

Can be rebased now that the dependent PRs are merged. Perhaps we should also update the neutrino dep as well?

@wpaulino
Copy link
Contributor Author

wpaulino commented Nov 9, 2019

Rebased! Tests still fail with bumping Travis to use v0.19.0 because it hasn't been officially released yet. We'll want to wait until that's done and re-run the test suite to ensure nothing has changed (test suite passes as is locally).

@wpaulino
Copy link
Contributor Author

@Roasbeef @halseth as discussed, we'll be postponing the Travis upgrade to bitcoind 0.19.0 until the binaries are out, so we can move forward with this PR.

go.mod Outdated Show resolved Hide resolved
The btcwallet update includes some edge-case wallet bug fixes and an
optimization on ZMQ connections for bitcoind backends.

The btcd update allows for compatibility with bitcoind v0.19.0 backends.
bitcoind's sendrawtransaction API in v0.19.0 now enforces a maximum fee
rate of 0.1 BTC/kb and valid output scripts.
@wpaulino wpaulino changed the title build+lnwallet: support bitcoind v0.19.0 build: bump btcsuite and neutrino dependencies to latest tagged versions Nov 13, 2019
v0.9.0-beta automation moved this from Needs Review to Approved Nov 15, 2019
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌋

@Roasbeef Roasbeef merged commit 2ab16f7 into lightningnetwork:master Nov 15, 2019
v0.9.0-beta automation moved this from Approved to Done Nov 15, 2019
@wpaulino wpaulino deleted the bitcoind-0.19-compat branch November 15, 2019 00:23
@wpaulino wpaulino restored the bitcoind-0.19-compat branch November 15, 2019 00:24
@wpaulino wpaulino deleted the bitcoind-0.19-compat branch November 15, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoind Bitcoin Core backend P2 should be fixed if one has time
Projects
No open projects
v0.9.0-beta
  
Done
5 participants