Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signrpc: add DeriveSharedKey #3777

Merged
merged 1 commit into from Jan 3, 2020
Merged

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Nov 29, 2019

Allow ECDH based shared key derivation.

This would allow multiple use cases where a sender wants to encrypt a message for a target node without prior key exchange.

@guggero guggero changed the title [WIP] walletrpc: add DeriveSharedKey walletrpc: add DeriveSharedKey Dec 17, 2019
@guggero guggero marked this pull request as ready for review December 17, 2019 13:26
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit.proto Outdated Show resolved Hide resolved
lnrpc/walletrpc/walletkit_server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍣

lnrpc/signrpc/signer.proto Outdated Show resolved Hide resolved
lnrpc/signrpc/signer.proto Outdated Show resolved Hide resolved
lnrpc/signrpc/signer_server.go Outdated Show resolved Hide resolved
@guggero guggero changed the title walletrpc: add DeriveSharedKey signrpc: add DeriveSharedKey Dec 20, 2019
Copy link
Collaborator

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Alice and Bob. Both derive the same shared secret 👍

@joostjager joostjager added this to WIP in v0.9.0-beta via automation Dec 22, 2019
@joostjager joostjager added this to the 0.9.0 milestone Dec 22, 2019
@joostjager joostjager moved this from WIP to Approved in v0.9.0-beta Dec 22, 2019
@Roasbeef Roasbeef merged commit 5ade9ab into lightningnetwork:master Jan 3, 2020
v0.9.0-beta automation moved this from Approved to Done Jan 3, 2020
@guggero guggero deleted the shared-key branch January 3, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.9.0-beta
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants