[trivial] typo in README #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this left me scratching my head too. |
Roasbeef
requested changes
Oct 15, 2016
| @@ -15,7 +15,7 @@ Don't try to port it to mainnet or an altcoin and use it today! No really. Lig | |||
| * **Go 1.5 or 1.6** | |||
|
|
|||
| Installation instructions can be found here: http://golang.org/doc/install. It is recommended to add `$GOPATH/bin` to your `PATH` at this point. | |||
| **Note:** If you are building with Go 1.5, then you'll need to enable the vendor experiment by setting the `GO15VENDOREXPERIMENT` environment variable to `1`. If you're using Go 1.5, then it is safe to skip this step. | |||
| **Note:** If you are building with Go 1.5, then you'll need to enable the vendor experiment by setting the `GO15VENDOREXPERIMENT` environment variable to `1`. If you're using Go 1.6, then it is safe to skip this step. | |||
There was a problem hiding this comment.
Minor nit, this should read:
If you're using Go 1.6 or later...
| @@ -15,7 +15,7 @@ Don't try to port it to mainnet or an altcoin and use it today! No really. Lig | |||
| * **Go 1.5 or 1.6** | |||
There was a problem hiding this comment.
While you're at it, can you modify this header to read Go 1.5+? Thanks!
jnewbery
force-pushed
the
trivial_typo
branch
from
5374bf3
to
961a79c
Compare
|
nit fixed |
|
Thanks! LGTM ✨ |
bjarnemagnussen
added a commit
to LN-Zap/lnd
that referenced
this pull request
Sep 13, 2021
…0.13.1.beta.rc2 Upgrade to LND 0.13.1
ioudkerk
pushed a commit
to clovrlabs/wallet-lnd
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a trivial typo in README