cmd/lncli: remove usage of Millisecond() for Go 1.12 #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new table format for the pay command started to use the `Millisecond()` method on `time.Duration`. However, this method was only added in Go 1.13, so this breaks the build for Go 1.12. We replace this by manual division. `time.Duration` "natively" is in nanoseconds, so we covert to milli seconds by dividing my `time.Millisecond`, which is 1,000,000.
joostjager
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new table format for the pay command started to use the
Millisecond()method ontime.Duration. However, this method was onlyadded in Go 1.13, so this breaks the build for Go 1.12. We replace this
by manual division.
time.Duration"natively" is in nanoseconds, so wecovert to milli seconds by dividing my
time.Millisecond, which is1,000,000.