Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing+routerrpc: add multiple outgoing channel restriction #4257

Merged

Conversation

joostjager
Copy link
Collaborator

@joostjager joostjager commented May 7, 2020

This PR adds the ability to restrict payment pathfinding to a set of outgoing channels. Prior to this, it was only possible to restrict to a single channel.

A use case of channel (set) selection is to not just make the payment, but also obtain the (right) inbound at the same time. This is also a building block that allows loop out channel set selection.

@joostjager joostjager requested a review from Roasbeef as a code owner May 7, 2020 09:49
@joostjager joostjager removed the request for review from Roasbeef May 7, 2020 09:49
@joostjager joostjager added payments Related to invoices/payments routing labels May 7, 2020
@joostjager joostjager force-pushed the multi-outgoing-chan-restriction branch 2 times, most recently from eb9da33 to dd4c577 Compare May 7, 2020 10:17
@Roasbeef Roasbeef self-requested a review May 7, 2020 19:14
@Roasbeef Roasbeef added this to the 0.10.1 milestone May 7, 2020
routing/pathfind.go Outdated Show resolved Hide resolved
routing/pathfind_test.go Outdated Show resolved Hide resolved
routing/pathfind_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question as to how we treat the deprecated field. Non-blocking.

lnrpc/routerrpc/router_backend.go Show resolved Hide resolved
@joostjager joostjager force-pushed the multi-outgoing-chan-restriction branch 2 times, most recently from 66ebc1a to 3968af8 Compare May 11, 2020 19:34
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚨

@joostjager joostjager force-pushed the multi-outgoing-chan-restriction branch from a334cbe to 7660e71 Compare May 12, 2020 05:17
@joostjager joostjager force-pushed the multi-outgoing-chan-restriction branch from 7660e71 to 25a50b6 Compare May 12, 2020 07:13
@joostjager
Copy link
Collaborator Author

Tested channel set restriction with loop out on a dev branch, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
payments Related to invoices/payments routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants