Persist rescan progress. #4425
Merged
Persist rescan progress. #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
force-pushed
the
persist-rescan-progress
branch
3 times, most recently
from
c920e38
to
cbd8fa8
Compare
Roasbeef
added
database
roeierez
force-pushed
the
persist-rescan-progress
branch
from
cbd8fa8
to
c8a3b8d
Compare
halseth
suggested changes
Sep 11, 2020
|
Still relevant? |
|
ping @roeierez |
|
IIRC @cfromknecht we were hesitant to include this due to some spooky interaction at a distance w.r.t the spend hints themselves? The functionality is already in neutrino, and this PR would just make that useable for lnd users. |
|
@cfromknecht ping |
|
@roeierez do you have the bandwidth to revive this PR? I take it Breez is already running this in production, correct? |
Adding persistency to neutrino re-scan progress. In case the re-scan failed in the middle or the node was restarted before the re-scan has been completed this fix will start from the last point instead of the beginning. On long re-scan , such as old channels on mobile devices this is crucial.
roeierez
force-pushed
the
persist-rescan-progress
branch
from
c8a3b8d
to
935e714
Compare
|
Rebased. |
|
ping @halseth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up to neutrino PR: lightninglabs/neutrino#198 and handles the use case where
old channels unable to finish their re-scan on mobile devices waisting lots of bandwidth on every restart.
While there is a mechanism of "SpendHint" cache to persist the rescan progress, it is only get updated at the end of the process.
This PR adds additional updates along the way in a similar way to how btcwallet does for the initial rescan.