Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: create all directories #4622

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Sep 16, 2020

Fixes #4572.

With this PR we make sure that all directories where lnd could
potentially want to write files to are created on startup. This fixes
the case where the lnddir isn't set but all other paths point to
explicit locations with non-existend parent directories.

We don't create the log dir as that's done by the log rotator already.

@guggero guggero added bug fix config Parameters/arguments/config file related issues/PRs v0.12 labels Sep 16, 2020
@guggero guggero added this to In progress in v0.12.0-beta via automation Sep 16, 2020
@guggero guggero added this to the 0.12.0 milestone Sep 16, 2020
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

config.go Outdated Show resolved Hide resolved
config.go Show resolved Hide resolved
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

With this commit we make sure that all directories where lnd could
potentially want to write files to are created on startup. This fixes
the case where the lnddir isn't set but all other paths point to
explicit locations with non-existend parent directories.

We don't create the log dir as that's done by the log rotator already.
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

v0.12.0-beta automation moved this from In progress to Reviewer approved Sep 18, 2020
@cfromknecht cfromknecht merged commit 98da919 into lightningnetwork:master Sep 18, 2020
v0.12.0-beta automation moved this from Reviewer approved to Done Sep 18, 2020
@guggero guggero deleted the config-mkdir branch September 19, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix config Parameters/arguments/config file related issues/PRs v0.12
Projects
No open projects
v0.12.0-beta
  
Done
Development

Successfully merging this pull request may close these issues.

LND will not create path specified by --tlscertpath
3 participants