Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer: abstractions to aid in unit testing #4645

Merged
merged 1 commit into from
Sep 25, 2020
Merged

peer: abstractions to aid in unit testing #4645

merged 1 commit into from
Sep 25, 2020

Conversation

Crypt-iQ
Copy link
Collaborator

@Crypt-iQ Crypt-iQ commented Sep 23, 2020 •
edited
Loading

Commit:

  • MessageConn interface that gets rid of the dependency on *brontide.Conn & remove Config from config.go per @halseth

@Crypt-iQ Crypt-iQ added p2p Code related to the peer-to-peer behaviour tests refactoring labels Sep 23, 2020
@Crypt-iQ Crypt-iQ added this to the 0.12.0 milestone Sep 23, 2020
halseth
halseth approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

peer/brontide.go Outdated Show resolved Hide resolved
@Crypt-iQ Crypt-iQ requested review from halseth and removed request for Roasbeef September 24, 2020 14:20
@Crypt-iQ Crypt-iQ mentioned this pull request Sep 25, 2020
Merged
halseth
halseth reviewed Sep 25, 2020
View reviewed changes
server.go Outdated Show resolved Hide resolved
halseth
halseth approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending squash 🌡️

bhandras
bhandras approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Crypt-iQ Crypt-iQ merged commit 0a8f066 into lightningnetwork:master Sep 25, 2020
@Crypt-iQ Crypt-iQ deleted the peer_messageconn branch September 25, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@halseth halseth halseth approved these changes

@cfromknecht cfromknecht Awaiting requested review from cfromknecht

Assignees
No one assigned
Labels
p2p Code related to the peer-to-peer behaviour refactoring tests
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Crypt-iQ @bhandras @halseth