lnrpc: expose linked htlcs in ListChannels #4693
Conversation
joostjager
force-pushed
the
listchannels-circuits
branch
from
368e3c8
to
5df6754
Compare
joostjager
force-pushed
the
listchannels-circuits
branch
2 times, most recently
from
952c623
to
ea16465
Compare
| }, | ||
| ) | ||
|
|
||
| // If the incoming channel id is the special hop.Source |
There was a problem hiding this comment.
hop.Source is a symbol :)
| // For an incoming htlc, it is the outgoing channel. When the htlc | ||
| // originates from this node or this node is the final destination, | ||
| // forwarding_channel will be zero. | ||
| uint64 forwarding_channel = 6; |
There was a problem hiding this comment.
nit: since we can have a nil outgoing circuit, is it possible that we have a forwarded htlc that will have a 0 forwarding channel (temporarily)? Not the most familiar with that part of the switch, if possible perhaps update the comment so that people don't rely on 0 value meaning own payment.
There was a problem hiding this comment.
Comment added. I considered making this state explicit, but I don't think it is necessary. Htlcs that need to be forwarded, but haven't even reached the circuit map will also be reported with a zero forwarding_channel.
joostjager
force-pushed
the
listchannels-circuits
branch
from
ea16465
to
49df2d6
Compare
Roasbeef
requested review from
bhandras
and removed request for
cfromknecht and
Roasbeef
|
Anything blocking merge on this one? |
No, forgot you don't have merge powers anymore tbh :) Travis looks confused over the "sample configuration check" - happened to me on a PR that was opened before it was added. Restarting the actions now, then will merge if that does the trick, otherwise you may need to push again to jump it. |
|
@joostjager won't you push again? Looks like sample config check is stuck. |
Fixes #4687