discovery: allow DNS seeds to be overwritten #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
added
p2p
Roasbeef
reviewed
Nov 4, 2020
lncfg/chain.go
Outdated
| @@ -21,4 +21,5 @@ type Chain struct { | |||
| BaseFee lnwire.MilliSatoshi `long:"basefee" description:"The base fee in millisatoshi we will charge for forwarding payments on our channels"` | |||
| FeeRate lnwire.MilliSatoshi `long:"feerate" description:"The fee rate used when forwarding payments on our channels. The total fee charged is basefee + (amount * feerate / 1000000), where amount is the forwarded amount."` | |||
| TimeLockDelta uint32 `long:"timelockdelta" description:"The CLTV delta we will subtract from a forwarded HTLC's timelock value"` | |||
| DNSSeeds []string `long:"dnsseed" description:"The seed DNS server(s) to use for initial peer discovery. Can be specified multiple times, will overwrite the default seed servers."` | |||
There was a problem hiding this comment.
How do we want to handle the fall back SOA address? FWIW, it's a hack we use to allow people to do the SRV requests over Tor using direct TCP DNS resolution, and isn't actually in the spec.
There was a problem hiding this comment.
It'll just skip the SOA address if none was specified:
if dnsSeedTuple[1] == "" {
log.Tracef("DNS seed %v has no secondary, "+
"skipping fallback", primarySeed)
continue
}
So non-Tor users probably don't need to specify one. I added the possibility to specify a primary and SOA fallback address as a comma separated pair.
guggero
force-pushed
the
dns-seed-config
branch
from
1746c2b
to
0804240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3817.
Need to manually test on testnet, but should be pretty straightforward.