release: actually create deterministic release archives #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
added
golang/build system
|
Seems like I got somewhat different results as the manifest file's contents are: |
|
Hmmm... interesting, the builds from GitHub also don't match mine. At least the hashes of the extracted binaries seem to match, so it's still a packaging issue. |
guggero
force-pushed
the
release-fix
branch
5 times, most recently
from
3a06fab
to
843963c
Compare
|
This was harder than I expected.
Got it fully working now, though: https://github.com/guggero/lnd/releases/download/v0.12.0-beta.rc3-testbuild1/manifest-v0.12.0-beta.rc3-testbuild1.txt |
halseth
reviewed
Dec 22, 2020
guggero
force-pushed
the
release-fix
branch
5 times, most recently
from
6eda5d4
to
df7cd40
Compare
To make sure git has the full history, including all annotated tags, we need to explicitly fetch everything on checkout.
|
@bhandras I pushed up a new tag with the latest changes, it's ready to be re-tested (see updated instructions in PR description). |
|
@guggero Still not getting same hashes one macOS: |
guggero
force-pushed
the
release-fix
branch
2 times, most recently
from
c225be9
to
89a6a46
Compare
guggero
force-pushed
the
release-fix
branch
2 times, most recently
from
21067f3
to
ba3bffe
Compare
A number of tricks need to be applied to the tar and zip commands respectively to make sure they always produce deterministic archives. This includes setting the file timestamps to a fixed date and setting specific ownership attributes (tar) or no attributes at all (zip).
|
Manifest matches (although I had to sort the file first). |
Roasbeef
reviewed
Jan 8, 2021
| @@ -10,13 +10,11 @@ defaults: | |||
| shell: bash | |||
|
|
|||
| env: | |||
| DOCKER_REPO: lightninglabs | |||
There was a problem hiding this comment.
Cleared up offline: these env variables were never even used in the first place!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of small issues that lead to the release artifact hashes not matching up with local builds.
git describeworks correctly.git describe --tagsto identify the commit name compiled into the binaries..tar.gzand.zipfiles.A test run is in progress on GitHub: https://github.com/guggero/lnd/runs/1669502010?check_suite_focus=true
Will validate against my local build and report back on it.
Anyone trying to reproduce the same hashes can do the following (using
go 1.15.6!):This results in the following hashes: manifest-v0.12.0-beta.rc3-testbuild7.txt (on my local machine).
MacOS users:
There is now a docker image that helps you create reproducible builds. please run the same steps as above but replace
make releasewithmake docker-release!