[gossiper] Ignore received ChannelAnnouncements for own channels #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
ignore-local-ann-from-remote
branch
2 times, most recently
from
42be9da
to
094b259
Compare
cfromknecht
approved these changes
Jan 7, 2021
| @@ -544,7 +544,7 @@ func (d *AuthenticatedGossiper) ProcessRemoteAnnouncement(msg lnwire.Message, | |||
| // entire channel announcement and update messages will be re-constructed and | |||
| // broadcast to the rest of the network. | |||
| func (d *AuthenticatedGossiper) ProcessLocalAnnouncement(msg lnwire.Message, | |||
| source *btcec.PublicKey, optionalFields ...OptionalMsgField) chan error { | |||
|
hmm unit tests are unhappy |
Roasbeef
requested changes
Jan 7, 2021
| // To avoid inserting edges in the graph for our own channels that we | ||
| // have already closed, we ignore such channel announcements coming | ||
| // from the remote. | ||
| case *lnwire.ChannelAnnouncement: |
There was a problem hiding this comment.
Interesting, I guess this could happen after SCB recovery, the channel isn't yet closed, but we learn about it? I wonder why this didn't show up in any of the SCB itests.
There was a problem hiding this comment.
I think it can also happen just after you have closed a channel, then someone send you the announcement?
Roasbeef
reviewed
Jan 7, 2021
|
Uh, yeah need to fix the unit tests. |
halseth
force-pushed
the
ignore-local-ann-from-remote
branch
from
094b259
to
fb77b2b
Compare
Roasbeef
added
database
halseth
force-pushed
the
ignore-local-ann-from-remote
branch
2 times, most recently
from
359711d
to
d335992
Compare
|
Needs a rebase! |
halseth
force-pushed
the
ignore-local-ann-from-remote
branch
from
d335992
to
c04d32f
Compare
It will be the same announcement, no need to distinguish.
To make it more clear what is local and remote messages, we change to use `selfKey` only for local messages.
To avoid learning about our own channel we have already closed and removed from our graph, we ignore all ChannelAnns for channels we are involved in.
halseth
force-pushed
the
ignore-local-ann-from-remote
branch
from
c04d32f
to
926005a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4690