itest: fix wrong node queried for balance #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The itest fails, with the following line, |
yyforyongyu
force-pushed
the
fix-itest-channel-close
branch
from
17e0f05
to
efc0af3
Compare
Turns out that was the miner fee. |
yyforyongyu
force-pushed
the
fix-itest-channel-close
branch
from
efc0af3
to
46b0cd8
Compare
yyforyongyu
requested review from
bhandras and
guggero
and removed request for
halseth
guggero
approved these changes
Jun 3, 2021
yyforyongyu
force-pushed
the
fix-itest-channel-close
branch
from
46b0cd8
to
140a35e
Compare
Yep I think so. When we set up the test we |
yyforyongyu
force-pushed
the
fix-itest-channel-close
branch
from
140a35e
to
a60db53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at the channel force close test and found the wrong node was used to query the balance. (weird as it should have been caught by the test?)
testChannelForceClosurehas only two relevant participants,Alice(notnet.Alice) andCarol, seems likenet.Bobdoesn't belong here.