build: add new GH actions to require release note updates #5520
Conversation
|
Uuuh, nice! The check is currently failing with |
Doubled checked and it's executable in my local branch. I think maybe it's that the file isn't yet committed by the time the final commit is run? Gonna try to commit the file in the first commit, and use it in the second. |
|
Or actually, I'll just add a commit that adds this change to the release notes, that way we can verify it passes properly. |
There was a problem hiding this comment.
Seems to not be running because of the missing git checkout in the workflow step.
Tested this locally and can confirm it works correctly.
Only thing is: This will make it necessary to submit the PR first and then add the release notes once you know what PR number you get. But I guess that's inevitable...
In this commit, we add a simple bash script to parse out the current PR number from an environment variable in the GH actions context, and use that to check to see if the PR has been referenced in the release notes or not. This isn't 100% fool proof, but it should catch most of the common cases.
Roasbeef
force-pushed
the
actions-require-release-notes
branch
from
9f80eba
to
1219795
Compare
|
@guggero thanks for the additional pass! Looks like that did it.
Yeah not sure if there's a good way around that.... |
In this commit, we add a simple bash script to parse out the current PR
number from an environment variable in the GH actions context, and use
that to check to see if the PR has been referenced in the release notes
or not. This isn't 100% fool proof, but it should catch most of the
common cases.