New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discovery: revamp premature update map #5902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linter fails, which is also the reason for the Travis failure:
I looked at some of the itest failures:
|
Crypt-iQ
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some minor nits 🍳
Turns out we need it right now to handle some low latency race conditions in our integration tests, so we'll opt to simply cap the size of it to a low amount. We use a basic LRU caching mechainsm. Fixes lightningnetwork#5076
Similar to the prior commit, in this commit, we move to using a basic LRU cache to store the set of prior rejected messages.
Roasbeef
force-pushed
the
lru-chan-upd
branch
from
November 4, 2021 22:24
28b04b2
to
75ae7e6
Compare
positiveblue
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
guggero
added a commit
to guggero/lnd
that referenced
this pull request
Jan 3, 2022
Fixes a nil pointer dereference panic introduced by lightningnetwork#5902. Since peer is an interface the value can actually be nil. This is probably a symptom of another problem but I'm not really familiar with this part of the code base, so this just adds some band aids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we need it right now to handle some low latency race
conditions in our integration tests, so we'll opt to simply cap the size
of it to a low amount. We use a basic LRU caching mechainsm.
Fixes #5076