Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: don't optimize debug binaries #6105

Merged
merged 2 commits into from Jan 3, 2022
Merged

make: don't optimize debug binaries #6105

merged 2 commits into from Jan 3, 2022

Conversation

liviu-ln
Copy link
Contributor

@liviu-ln liviu-ln commented Dec 20, 2021 •
edited

Disable compiler optimizations and function inlining on a debug build to
improve debugging experience.

@liviu-ln
make: don't optimize debug binaries
abada24 
Disable compiler optimizations and function inlining on a debug build to
improve debugging experience.
guggero
guggero reviewed Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. This either needs an entry in the 0.15 release notes or the [skip ci] suffix in the commit message title.

guggero
guggero approved these changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@liviu-ln
Copy link
Contributor Author

Is there anything else that needs my attention before the PR can be merged?

@guggero
Copy link
Collaborator

guggero commented Jan 3, 2022

No, this just needs a second reviewer. Going to pick someone.

@guggero guggero requested a review from bhandras January 3, 2022 10:01
bhandras
bhandras approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@guggero guggero merged commit 2aad76a into lightningnetwork:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liviu-ln @guggero @bhandras