Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lncli: remove confusing default 0 for time lock delta #6778

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Jul 29, 2022

Note: depends on #6777

Change Description

This changes the output of lncli updatechanpolicy --help from

--time_lock_delta value  the CLTV delta that will be applied to all forwarded HTLCs (default: 0)

to

--time_lock_delta value  the CLTV delta that will be applied to all forwarded HTLCs (default: no default)

This fixes #1523

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

馃摑 Please see our Contribution Guidelines for further guidance.

@C-Otto C-Otto force-pushed the fix-default-value-for-time-lock-delta branch from faf61a4 to ce4483d Compare July 29, 2022 20:00
@C-Otto C-Otto mentioned this pull request Jul 29, 2022
7 tasks
@C-Otto C-Otto force-pushed the fix-default-value-for-time-lock-delta branch from ce4483d to 4a10af2 Compare July 29, 2022 20:06
@C-Otto C-Otto marked this pull request as ready for review July 29, 2022 20:19
@C-Otto C-Otto force-pushed the fix-default-value-for-time-lock-delta branch from 4a10af2 to 245558e Compare July 30, 2022 08:04
@C-Otto C-Otto force-pushed the fix-default-value-for-time-lock-delta branch from 245558e to 976d9e4 Compare July 30, 2022 08:45
@Roasbeef
Copy link
Member

Overlap with #6762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lnd updatechanpolicy has confusing --help
2 participants