Adds data volume to lnd docker service #697

Osso · 2018-01-30T21:05:41Z

This is my proposed changes for issue #696

Osso · 2018-01-30T21:19:49Z

This still needs the handling of lncli. It's looking for the macaroon in /root/.lnd
Somehow, this needs to be set --macaroonpath=/data/admin.macaroon

Osso · 2018-01-31T02:02:39Z

I added a symlink creation during the container startup to be able to use lncli again without any argument.

dabura667 · 2018-02-03T09:24:54Z

You should never make a new folder in /

Osso · 2018-02-03T15:16:01Z

Actually, I did not create a new folder. The logs were already stored in /data

That said, Docker is a bit different. Since it's isolated it is quite common to store things in /

dabura667 · 2018-02-03T16:35:41Z

Why not use ~/.lnd default directory? Then you won’t need to make a symlink.

Osso · 2018-02-03T17:12:39Z

I find it cleaner to store data in /data and that's why I wrote it this way. If this was outside of docker I would store it in /var/lib/lnd. The home directory is not where I usually store application data.

It's definitely possible to make /root/.lnd a volume instead. I'll follow the devs opinion.

halseth · 2018-02-05T22:57:59Z

I think using ~/.lnd makes the most sense, since that is what is used on Linux. Won't that be the folder used by default for docker?

Osso · 2018-02-06T04:11:17Z

Ok I updated the patch to make /root/.lnd a volume and removed the --datadir option

Richard87 · 2018-02-07T14:52:46Z

What about adding VOLUME /root/.lnd to the lnd dockerfile? Then Docker would create an anonymous volume if not specified when starting a container/image... May prevent dataloss and help users of the image to know what volumes to mount :)

Osso · 2018-02-07T15:08:11Z

Good idea, I added it.

dabura667 · 2018-02-09T23:09:13Z

This should also contain a fix to the docker example readme.

It breaks the current explanation because when you try to make two lnd containers in the same host they can’t be separated, and use the same volume.

You should modify the docker/README.md to add volume parameters for alice and bob to allow separate volumes.

Osso · 2018-02-14T20:27:08Z

I wrote an update docker-compose.yml to add an alice and bob with different volumes.

I am not sure we want to clutter that file with services that are only useful in the tutorial. It is possible to put them in a different docker compose file but then I need to create network for them to share.

halseth

Possible to do the changes to the README without changing the formatting? Makes it hard to see what has really changed atm 😛

halseth · 2018-02-15T10:39:23Z

docker/docker-compose.yml

+      volumes:
+          - lnd_btc_data:/root/.lnd
+
+    alice:


Could you make the changes to this file a separate commit that explains what they achieve?

Osso · 2018-02-15T15:37:56Z

I re-split the changes into 3 commits:

the trailing spaces
the necessary lnd volumes to prevent data loss
the updates to make docker/readme work again

It should be more readable now

halseth · 2018-04-20T07:17:16Z

@Osso Are these changes/instructions up-to-date with latest master?

Osso · 2018-04-20T15:21:26Z

Mostly, the changes are still needed but the trailing spaces commit must be redone for the new readme.

halseth · 2018-08-17T21:57:14Z

@Osso Any updates on this? Seems useful (I just cherry-picked the commit to use for some testing) 😅

halseth · 2018-08-17T22:01:18Z

docker/docker-compose.yml

+      links:
+          - "btcd:blockchain"
+      volumes:
+          - alice_data:/root/.lnd


This doesn't seem to work, as Alice an Bob will share the same folder, and won't be able to run at the same time.

alice_data and bob_data are 2 different volumes and won't conflict.

Okay, will need to do some more testing, running into some issues... Will report back!

Osso · 2018-08-17T22:04:54Z

It's quite an old patch. I moved and did not have time to keep it up.

halseth · 2018-08-20T06:38:13Z

docker/README.md

@@ -90,7 +90,7 @@ Connect `Bob` node to `Alice` node.

 ```bash
 # Run "Bob" node and log into it:
-$ docker-compose run -d --name bob lnd_btc
+$ docker-compose run -d bob


This still needs to inlcude the --name parameter, since if not the container will be given a random name.

yancyribbens · 2019-01-18T21:32:52Z

docker/lnd/Dockerfile

@@ -34,3 +34,5 @@ RUN apk add --no-cache \
 # Copy the entrypoint script.
 COPY "docker/lnd/start-lnd.sh" .
 RUN chmod +x start-lnd.sh
+
+VOLUME /root/.lnd


Looks like this isn't actually needed if we use a named volume in docker-compose

yancyribbens · 2019-01-18T21:38:20Z

docker/docker-compose.yml

@@ -82,12 +82,29 @@ services:
      container_name: lnd_ltc
      links:
          - "ltcd:blockchain"
+      volumes:
+          - lnd_ltc_data:/root/.lnd


The volume shouldn't be required here if you've already defined it in the Dockerfile I believe. Is there any reason why you're also setting it up here?

I am mirroring the way volumes are set up for the other services.
e.g. - litecoin:/data
Also, I prefer having a named volume for ease of management.

After doing some further testing it seems docker-compose requires this named volume for management instead of an anonymous volume which is what's created in the Dockerfile.

yancyribbens · 2019-01-18T21:39:03Z

docker/docker-compose.yml


    lnd_btc:
      extends: lnd
      container_name: lnd_btc
      links:
          - "btcd:blockchain"
+      volumes:
+          - lnd_btc_data:/root/.lnd


Same comment here. shouldn't require it this volume if you create it in lnd/Dockerfile

yancyribbens · 2019-01-18T21:43:00Z

docker/README.md


 # Run the "Alice" container and log into it:
-$ docker-compose run -d --name alice lnd_btc
+$ docker-compose run -d --name alice alice


I think it's a good idea to simplify the docs here, although it would be better to do something like:
docker-compose exec -it --name alice and name the container when it's run.

yancyribbens · 2019-01-23T14:35:24Z

docker/docker-compose.yml

+     driver: local
+
+  # alice and bob are need for running README examples
+  alice_data:


IMO this docker-compose file should be left agnostic to implementation examples.

guggero · 2019-11-07T14:21:42Z

This is a very old PR and we probably should have reviewed it a long time ago.
I'm not a fan of adding tutorial specific things into the docker-compose file, since people might use that for their setup outside of just the tutorial.
I left some suggestions in #2533 on how to do this and am closing this PR in favor of the newer one.

meshcollider added the docker Docker-related PRs/Issues label Jan 31, 2018

Osso force-pushed the lnd-docker branch from 86814b3 to 266ecb0 Compare February 1, 2018 01:28

Osso force-pushed the lnd-docker branch from 266ecb0 to 839f2b1 Compare February 6, 2018 04:09

Osso force-pushed the lnd-docker branch from 839f2b1 to 7d58e30 Compare February 7, 2018 15:07

Osso force-pushed the lnd-docker branch from 7d58e30 to 3b3b54e Compare February 7, 2018 19:10

halseth suggested changes Feb 15, 2018

View reviewed changes

Osso force-pushed the lnd-docker branch from d8dc3d2 to 7b8cb2e Compare February 15, 2018 15:38

Roasbeef added the P3 might get fixed, nice to have label Jul 10, 2018

halseth reviewed Aug 17, 2018

View reviewed changes

Osso added 2 commits August 17, 2018 17:07

Adds data volume to lnd docker service

ee99015

Defines volumes for alice/bob in docker/README

7e4aa29

Osso force-pushed the lnd-docker branch from 7b8cb2e to 7e4aa29 Compare August 17, 2018 22:07

halseth reviewed Aug 20, 2018

View reviewed changes

Osso added 2 commits August 22, 2018 19:45

Remove trailing whitespace in docker/README

0fb2cd1

Give a name to Alice and Bob docker containers

eee12ad

Osso force-pushed the lnd-docker branch from 7965f5f to eee12ad Compare August 23, 2018 00:46

halseth modified the milestones: 0.5.1, 0.5.2 Sep 19, 2018

Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019

Roasbeef mentioned this pull request Jan 18, 2019

add volume to lnd to persist chain state across container changes #2507

Closed

yancyribbens reviewed Jan 18, 2019

View reviewed changes

yancyribbens reviewed Jan 23, 2019

View reviewed changes

halseth mentioned this pull request Jan 28, 2019

add named volume to lnd service for persisting data accross container… #2533

Merged

halseth requested a review from guggero November 7, 2019 11:27

guggero self-assigned this Nov 7, 2019

guggero closed this Nov 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds data volume to lnd docker service #697

Adds data volume to lnd docker service #697

Osso commented Jan 30, 2018

Osso commented Jan 30, 2018

Osso commented Jan 31, 2018

dabura667 commented Feb 3, 2018

Osso commented Feb 3, 2018

dabura667 commented Feb 3, 2018

Osso commented Feb 3, 2018

halseth commented Feb 5, 2018

Osso commented Feb 6, 2018

Richard87 commented Feb 7, 2018 •

edited

Osso commented Feb 7, 2018

dabura667 commented Feb 9, 2018

Osso commented Feb 14, 2018 •

edited

halseth left a comment

halseth Feb 15, 2018

Osso commented Feb 15, 2018

halseth commented Apr 20, 2018

Osso commented Apr 20, 2018

halseth commented Aug 17, 2018

halseth Aug 17, 2018

Osso Aug 17, 2018

halseth Aug 17, 2018

Osso commented Aug 17, 2018

halseth Aug 20, 2018

yancyribbens Jan 18, 2019

yancyribbens Jan 23, 2019

yancyribbens Jan 18, 2019

Osso Jan 18, 2019

yancyribbens Jan 23, 2019

yancyribbens Jan 18, 2019

yancyribbens Jan 18, 2019 •

edited

yancyribbens Jan 23, 2019

guggero commented Nov 7, 2019

Adds data volume to lnd docker service #697

Adds data volume to lnd docker service #697

Conversation

Osso commented Jan 30, 2018

Osso commented Jan 30, 2018

Osso commented Jan 31, 2018

dabura667 commented Feb 3, 2018

Osso commented Feb 3, 2018

dabura667 commented Feb 3, 2018

Osso commented Feb 3, 2018

halseth commented Feb 5, 2018

Osso commented Feb 6, 2018

Richard87 commented Feb 7, 2018 • edited

Osso commented Feb 7, 2018

dabura667 commented Feb 9, 2018

Osso commented Feb 14, 2018 • edited

halseth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Osso commented Feb 15, 2018

halseth commented Apr 20, 2018

Osso commented Apr 20, 2018

halseth commented Aug 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Osso commented Aug 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yancyribbens Jan 18, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guggero commented Nov 7, 2019

Richard87 commented Feb 7, 2018 •

edited

Osso commented Feb 14, 2018 •

edited

yancyribbens Jan 18, 2019 •

edited