[8/?] - lncli+lnrpc: add support for creating unadvertised taproot channels #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
reviewed
Mar 5, 2023
hieblmi
reviewed
Mar 5, 2023
hieblmi
reviewed
Mar 5, 2023
Roasbeef
changed the base branch from
master
to
simple-taproot-chans-funding-mgr
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
d0a1e0a
to
90ff4b1
Compare
ellemouton
reviewed
Apr 27, 2023
Comment on lines
+2137
to
+2139
| // TODO(roasbeef): no need for the rest as they're now | ||
| // implicit? | ||
|
|
There was a problem hiding this comment.
are they? cant I want to support taproot chans but not want zero conf chans?
| default: | ||
| return nil, fmt.Errorf("unhandled request channel type %v", | ||
| in.CommitmentType) | ||
| } | ||
|
|
||
| // TODO(roasbeef): make taproot the default chan type? |
There was a problem hiding this comment.
perhaps we should wait a bit & give users ample warning that we will switch the default type?
There was a problem hiding this comment.
Yep won't be the default type for a looong time
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
2 times, most recently
from
7b91e27
to
a9dd0f4
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
90ff4b1
to
077b57d
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
2 times, most recently
from
138c6c5
to
c8e9287
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
2 times, most recently
from
171e993
to
e47cced
Compare
|
@Roasbeef, remember to re-request review from reviewers when ready |
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
from
e47cced
to
8cfdf30
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
077b57d
to
a3901c7
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
from
8cfdf30
to
a1b6a0d
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
4e0e94c
to
b7ebb59
Compare
yyforyongyu
requested changes
Jul 26, 2023
Roasbeef
force-pushed
the
simple-taproot-chans-funding-mgr
branch
from
a1b6a0d
to
ea25054
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
b7ebb59
to
ba034cb
Compare
Roasbeef
changed the base branch from
simple-taproot-chans-funding-mgr
to
simple-taproot-chans-staging
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
ba034cb
to
00a66b3
Compare
Roasbeef
force-pushed
the
simple-taproot-chans-cli-rpc
branch
from
00a66b3
to
7598dae
Compare
Roasbeef
merged commit 96cceb1
into
lightningnetwork:simple-taproot-chans-staging
18 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Depends on #7346.
Only the last 3 commits are new.
In this PR, we update the CLI+RPC interface to allow new taproot channels to be created.
The next PR in this series will tackle the contract court and the sweeper, to enable full on chain interaction and HTLC resolution for the new channels.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.